Moti Asayag has posted comments on this change.

Change subject: core: Change spec params type to HashMap
......................................................................


Patch Set 1: (3 inline comments)

a new patch will be added to address those issues.

Please note that a preliminary patch is added to modify the signature of the 
Object serialization method.

....................................................
File backend/manager/dbscripts/upgrade/03_01_0930_convert_spec_param_to_json.sql
Line 8:     value text; 
Done

Line 13: for params in select * from regexp_split_to_table(v_spec_param, ',') 
as param
Done

Line 16:     if (key != 'deviceId') then
Done

--
To view, visit http://gerrit.ovirt.org/3763
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07f4981977b2ca271ebf3f4c4770b62545a9769
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to