Eli Mesika has posted comments on this change.
Change subject: core: Change spec params type to HashMap
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_01_0930_convert_spec_param_to_json.sql
Line 8: value text;
please remove TWS
Line 13: for params in select * from regexp_split_to_table(v_spec_param, ',')
as param
Keep in mind that the value of spec_params in database may have a leading and
trailing "{" , you should have trim that as well.
Line 16: if (key != 'deviceId') then
Just add a comment why are you skipping deviceId
--
To view, visit http://gerrit.ovirt.org/3763
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07f4981977b2ca271ebf3f4c4770b62545a9769
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
