Mike Kolesnik has posted comments on this change. Change subject: core: Change spec params type to HashMap ......................................................................
Patch Set 1: (1 inline comment) Why set all the "new HashMap<String, Object>()" if you treat null & empty string the same, and that you even allow null then it can be just null or empty sting. Besides, you can use Collections.emptyMap() instead of this call each time (if you do plan to set a map each time). Also in cases where only one value is set to map you can use Collections.signletonMap(K, V) call instead of creating the map yourself.. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java Line 243: VmDeviceType.DISK, VmDeviceType.DISK, null, true, false); Why send null here? -- To view, visit http://gerrit.ovirt.org/3763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07f4981977b2ca271ebf3f4c4770b62545a9769 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
