Ravi Nori has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/GenericVdcParameter.java
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GenericVdcParameter<T> extends VdcParameter<T> {
Line 6:
Line 7: public final static GenericVdcParameter GUID_ID = new
GenericVdcParameter<Guid>("GUID_ID", Guid.class);
My answer above answers your question, if we want to have one big class it is
fine, but if we want to have separate classes for that each group can maintain,
we need inheritance
Line 8:
Line 9: /**
Line 10: * Needed by Json Serialization/Deserialization
Line 11: */
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameter.java
Line 1: package org.ovirt.engine.core.common.utils;
Line 2:
Line 3: import java.io.Serializable;
Line 4:
Line 5: public abstract class VdcParameter<T> implements Serializable {
This is a convenience method to define all the fields and methods that
Parameter classes need. So in future when we declare a new class
class StorageParameters<T> extends VdcParameters<T>
the storage parameters class will inherit all the methods declared here and
will act as a template for the new parameters class.
Line 6:
Line 7: private String name;
Line 8: private Class<T> javaType;
Line 9:
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
