Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 2:
(2 comments)
If I wish to summarize...
1. really want to see a solution that will enable us to split the parameters
into several files maintained by different people, without ugly java overhead.
worse case we generate java code from properties file.
2. I do not want to see intermediate class for value used all over program. The
serialziation should be not impact the actual use.
Thanks!
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameter.java
Line 6: public enum VdcParameter implements IVdcParameter {
Line 7: ClusterId(Guid.class),
Line 8: DataCenterId(Guid.class),
Line 9: RoleId(Guid.class),
Line 10: StorageDomainId(Guid.class);
Can't annotations help here?
The other alternative is to generate the enum out of several properties files
during build.
Line 11:
Line 12: private final Class javaType;
Line 13:
Line 14: VdcParameter(Class javaType) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameterValue.java
Line 2:
Line 3: import java.io.Serializable;
Line 4: import
org.ovirt.engine.core.common.queries.InvalidParameterValueException;
Line 5:
Line 6: public class VdcParameterValue<T> implements Serializable {
yes, but this is a rason to have the map not class for every element.
Line 7:
Line 8: private IVdcParameter key;
Line 9: private T value;
Line 10:
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
