Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 3:
(6 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
Line 66: this.isFiltered = isFiltered;
Line 67: }
Line 68:
Line 69: public <T> void addParameter(VdcParameter param, T value) {
Line 70: paramsMap.<T>put(param, value);
please return this for all addParameter, this will enable:
RunQuery(prms.addParameter(x, y).addParameter(x, y).addParameter(x,y))
Line 71: }
Line 72:
Line 73: public <T> T getParameterValue(VdcParameter<T> param) {
Line 74: return paramsMap.<T>get(param, param.getJavaType());
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/GenericVdcParameter.java
Line 1: package org.ovirt.engine.core.common.utils;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GenericVdcParameter<T> extends VdcParameter<T> {
why do we need the inheritance?
Line 6:
Line 7: public final static GenericVdcParameter GUID_ID = new
GenericVdcParameter<Guid>("GUID_ID", Guid.class);
Line 8:
Line 9: /**
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GenericVdcParameter<T> extends VdcParameter<T> {
Line 6:
Line 7: public final static GenericVdcParameter GUID_ID = new
GenericVdcParameter<Guid>("GUID_ID", Guid.class);
why this cannot be of type VdcParameter?
Line 8:
Line 9: /**
Line 10: * Needed by Json Serialization/Deserialization
Line 11: */
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameter.java
Line 1: package org.ovirt.engine.core.common.utils;
Line 2:
Line 3: import java.io.Serializable;
Line 4:
Line 5: public abstract class VdcParameter<T> implements Serializable {
Why is this needs to be template? we can just store plain "Object", no?
Line 6:
Line 7: private String name;
Line 8: private Class<T> javaType;
Line 9:
Line 4:
Line 5: public abstract class VdcParameter<T> implements Serializable {
Line 6:
Line 7: private String name;
Line 8: private Class<T> javaType;
we need GUID was well the GUID should be the key into the map, name is only
used for deug.
Line 9:
Line 10: /**
Line 11: * Needed by Json Serialization/Deserialization
Line 12: */
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendSubResource.java
Line 18: public abstract class AbstractBackendSubResource<R extends
BaseResource, Q /* extends IVdcQueryable */> extends
Line 19: AbstractBackendResource<R, Q> {
Line 20:
Line 21: protected static final String[] STRICTLY_IMMUTABLE = { "id" };
Line 22: protected static final Log LOG =
LogFactory.getLog(AbstractBackendSubResource.class);
not part of this patch, right?
Line 23:
Line 24: protected String id;
Line 25: protected Guid guid;
Line 26:
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
