Eli Mesika has posted comments on this change. Change subject: core: unable to start vm: incorrect boot order sent in CreateVmVdsCommand ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java Line 66: // update cached image Done .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java Line 73: // update vm device boot order Done .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 245: */ because VmBase is either VmStatic or VmTemplate depends if it is a VM or Template and in case of VmStatic we can get that from the vm by getStaticData() method so there is no point in passing both in VM , but in templates we will need both , I think that it mess the code -- To view, visit http://gerrit.ovirt.org/3332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e06b7119132ee17c8624b69ea863e0b54c3bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
