Eli Mesika has posted comments on this change. Change subject: core: unable to start vm: incorrect boot order sent in CreateVmVdsCommand ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java Line 66: // update cached image They did change , see updates to the image in rows 61-63 .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java Line 73: // update vm device boot order I am aware of that, do you have alternative option ? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 245: */ I had checked that , there are 4 places out of 8 that will have to retrieve it anyway , I don't want to send both VM & VmBase , its confusing and since this method serves both templates & vms , I need the VmBase as is . Actually , I need the Vm to determine if cluster is old, I can compute this boolean outside and send it as a parameter, but I think that it is less error prone to keep it encapsulated in the methos. >From those reasons I would like to keep the code as is. Also, in the relevant scenarios , you will not see any change in performance , those are rare operations in general -- To view, visit http://gerrit.ovirt.org/3332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e06b7119132ee17c8624b69ea863e0b54c3bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
