Yair Zaslavsky has posted comments on this change. Change subject: core: unable to start vm: incorrect boot order sent in CreateVmVdsCommand ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java Line 67: VmHandler.updateDisksFromDb(getVm()); Regarding Kublin's last comment - I agree with him. What should be done IMHO is to add a method to VmHandler that updates a vm with a single disk image (see the impelemtation of updateDisksFromDB - it uses another helper method which is public, so we can have another method for updating a single disk). Also, please make sure updatedisksfromdb updates all the relevant collections. -- To view, visit http://gerrit.ovirt.org/3332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e06b7119132ee17c8624b69ea863e0b54c3bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
