anmolbabu has uploaded a new change for review. Change subject: webadmin : units of time (sec/ min) in runtime column ......................................................................
webadmin : units of time (sec/ min) in runtime column Units of time (sec/ min) in runtime column in remove brick status and rebalance status dialog. Change-Id: I1b72bb58fb4fd0181c912c97842e10faf50d6296 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019599 Signed-off-by: Anmol Babu <anb...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/UptimeRenderer.java 2 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/20249/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java index 53af264..3fac455 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java @@ -25,6 +25,7 @@ import org.ovirt.engine.ui.webadmin.ApplicationResources; import org.ovirt.engine.ui.webadmin.section.main.presenter.popup.gluster.VolumeRebalanceStatusPopupPresenterWidget; import org.ovirt.engine.ui.webadmin.widget.table.column.RebalanceFileSizeColumn; +import org.ovirt.engine.ui.webadmin.widget.table.column.UptimeColumn; import com.google.gwt.core.client.GWT; import com.google.gwt.editor.client.SimpleBeanEditorDriver; @@ -165,10 +166,12 @@ } }, constants.rebalanceScannedFileCount()); - rebalanceHostsTable.addEntityModelColumn(new EntityModelTextColumn<GlusterVolumeTaskStatusForHost>() { + rebalanceHostsTable.addEntityModelColumn(new UptimeColumn<EntityModel>() { + @Override - protected String getText(GlusterVolumeTaskStatusForHost entity) { - return String.valueOf(entity.getRunTime()); + protected Double getRawValue(EntityModel object) { + // TODO Auto-generated method stub + return ((GlusterVolumeTaskStatusForHost)(object.getEntity())).getRunTime(); } }, constants.rebalanceRunTime()); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/UptimeRenderer.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/UptimeRenderer.java index 0ff4c9f..2f0ce4b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/UptimeRenderer.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/UptimeRenderer.java @@ -28,7 +28,7 @@ reply += hours + " h "; //$NON-NLS-1$ } else if (minutes > 0) { reply += minutes + " min "; //$NON-NLS-1$ - } else if (seconds > 0) { + } else if (seconds >= 0) { reply += seconds + " sec"; //$NON-NLS-1$ } -- To view, visit http://gerrit.ovirt.org/20249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b72bb58fb4fd0181c912c97842e10faf50d6296 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
