Kanagaraj M has posted comments on this change.
Change subject: webadmin : units of time (sec/ min) in runtime column
......................................................................
Patch Set 2:
(5 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 169: rebalanceHostsTable.addEntityModelColumn(new
FullTimeColumn<EntityModel>() {
Line 170:
Line 171: @Override
Line 172: protected Double getRawValue(EntityModel object) {
Line 173: // TODO Auto-generated method stub
Remove TODO
Line 174: return
((GlusterVolumeTaskStatusForHost)(object.getEntity())).getRunTime();
Line 175: }
Line 176: }, constants.rebalanceRunTime());
Line 177:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/FullTimeRenderer.java
Line 2:
Line 3: import com.google.gwt.text.shared.AbstractRenderer;
Line 4:
Line 5:
Line 6: public class FullTimeRenderer extends AbstractRenderer<Double> {
I would prefer this to be called as "HumanReadableTimeRenderer"
Line 7: private static final int SECONDS_IN_A_MINUTE = 60;
Line 8: private static final int SECONDS_IN_AN_HOUR = SECONDS_IN_A_MINUTE *
60;
Line 9: private static final int SECONDS_IN_A_DAY = SECONDS_IN_AN_HOUR * 24;
Line 10: @Override
Line 11: public String render(Double time) {
Line 12: StringBuilder formatTime = new StringBuilder();
Line 13:
Line 14: if ( time > SECONDS_IN_A_DAY) {
Line 15: formatTime.append(time/SECONDS_IN_A_DAY);
I don't think Double/int gives the result in int. Have you tested it?
Line 16: formatTime.append(" days " );//$NON-NLS-1$
Line 17: time = time % SECONDS_IN_A_DAY;
Line 18: }
Line 19: if( time > SECONDS_IN_AN_HOUR ) {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/UptimeRenderer.java
Line 27: } else if (hours > 0) {
Line 28: reply += hours + " h "; //$NON-NLS-1$
Line 29: } else if (minutes > 0) {
Line 30: reply += minutes + " min "; //$NON-NLS-1$
Line 31: } else if (seconds >= 0) {
Remove this file from this patch
Line 32: reply += seconds + " sec"; //$NON-NLS-1$
Line 33: }
Line 34:
Line 35: return reply;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/FullTimeColumn.java
Line 2:
Line 3: import
org.ovirt.engine.ui.common.widget.table.column.RenderedTextColumn;
Line 4: import org.ovirt.engine.ui.webadmin.widget.renderer.FullTimeRenderer;
Line 5:
Line 6: public abstract class FullTimeColumn<T> extends RenderedTextColumn<T,
Double> {
"HumanReadableTimeColumn"
Line 7:
Line 8: public FullTimeColumn() {
Line 9: super(new FullTimeRenderer());
Line 10: }
--
To view, visit http://gerrit.ovirt.org/20249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b72bb58fb4fd0181c912c97842e10faf50d6296
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
