Kanagaraj M has posted comments on this change.
Change subject: webadmin : units of time (sec/ min) in runtime column
......................................................................
Patch Set 1:
(1 comment)
This would show only the possible higher units, like days or hours or minutes.
When the actual run time is 105 minutes, Is it ok to show "1 h" instead of "1
hr 45 min" ?
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 169: rebalanceHostsTable.addEntityModelColumn(new
UptimeColumn<EntityModel>() {
Line 170:
Line 171: @Override
Line 172: protected Double getRawValue(EntityModel object) {
Line 173: // TODO Auto-generated method stub
remove TODO
Line 174: return
((GlusterVolumeTaskStatusForHost)(object.getEntity())).getRunTime();
Line 175: }
Line 176: }, constants.rebalanceRunTime());
Line 177:
--
To view, visit http://gerrit.ovirt.org/20249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b72bb58fb4fd0181c912c97842e10faf50d6296
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
