Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: revert nfs config on cleanup ......................................................................
Patch Set 12: > One 'logical' comment you may ignore... I would have modified content only > between the before and after... so first loop and find the before, then loop > until after, add whatever, and copy remaining. Actually, in the comment I wrote "before the first line", but after sending this I recalled that the code actually updates all lines. I think I prefer it that way and will fix the comment. Example: In ssl.conf, with multiple virtual hosts, we'll update all of them. In any case, I only add immediately before/after, so there is no sense in passing both - if you want your line to be added before the </Virtualhost> pass only this one, if you want after the <Virtualhost> pass this one. I think (didn't check) that current code will add in both if caller passes both. They are line markers, not range markers. -- To view, visit http://gerrit.ovirt.org/19001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
