Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: revert nfs config on cleanup ......................................................................
Patch Set 13: (1 comment) code looks good to me, just a comment about the commit message. I think we can ignore the before / after loop for now, but maybe a todo for when we'll have more time can be added. .................................................... Commit Message Line 5: CommitDate: 2013-10-13 17:07:41 +0300 Line 6: Line 7: packaging: setup: revert nfs config on cleanup Line 8: Line 9: Revert /etc/sysconfig/nfs to its original contents on cleanup. It seems that the only remaining thing to do is update this commit message, since the patch do a lot more than the above. Line 10: Line 11: Bug-Url: https://bugzilla.redhat.com/1013347 Line 12: Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Line 13: Signed-off-by: Sandro Bonazzola <sbona...@redhat.com> -- To view, visit http://gerrit.ovirt.org/19001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
