Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: revert nfs config on cleanup ......................................................................
Patch Set 9: (2 comments) .................................................... File packaging/setup/ovirt_engine_setup/util.py Line 43: def editConfigContent( Line 44: content, Line 45: params, Line 46: changed_lines=None, Line 47: comment_re='[#]*\s*', No, you are wrong :-) Staffing this into the regexp with re.VERBOSE causes it to be treated as a re comment. Spent a long time on this - error messge was: "unbalanced parenthesis", and I tested it together with nested group original (soon pushing) so I thought I have some bug with named nested groups syntax :-( Line 48: comment='# ', Line 49: separator_re='\s*=\s*', Line 50: separator=' = ', Line 51: ): Line 69: Params that appear uncommented in the input, are commented, and new Line 70: values are added after the commented lines. Params that appear only Line 71: commented in the input, the comments are copied as-is, and new lines Line 72: are added after the comments. Params that do not appear in the input Line 73: are added in the end. OK, I added "added_params" for now. Alon - again: Give me an example. ssl.conf? What will be your barrier? Line 74: """ Line 75: # TODO: Add more options that will allow using this function Line 76: # in other places. Examples: Line 77: # setup/plugins/ovirt-engine-setup/apache/ssl.py -- To view, visit http://gerrit.ovirt.org/19001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
