anmolbabu has posted comments on this change. Change subject: webadmin : Change volume status to yellow when bricks down ......................................................................
Patch Set 13: Verified+1 Done But,I was doing almost the same(regarding counting of up and down bricks) but offcouse with a boolean instead of another integer (count) and that i!=0 is only bcoz initially when it starts with a up brick it would other wise directly return bcoz the boolean is true by default. I have implemented your suggestion in my latest patch.And this avoids some extra comparisons that I was doing -- To view, visit http://gerrit.ovirt.org/19611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
