Kanagaraj M has posted comments on this change. Change subject: webadmin : Change volume status to yellow when bricks down ......................................................................
Patch Set 10: (1 comment) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java Line 84: mayNotExit = true; Line 85: count++; Line 86: } Line 87: } Line 88: return count; simpler logic would be having two counters one for up and another one for down if brick is UP then up++ else down++ if both up and down counters are non-zero then break the loop or go till the end of the loop then return only the down count Line 89: } Line 90: -- To view, visit http://gerrit.ovirt.org/19611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
