Kanagaraj M has posted comments on this change.

Change subject: webadmin : Change volume status to yellow when bricks down
......................................................................


Patch Set 17:

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java
Line 59:                 statusImage = resources.downImage();
Line 60:                 tooltip = constants.down();
Line 61:             }
Line 62: 
Line 63:             ImageResource alertImage = resources.alertImage();
There is an extra indentation in the above lines, please remove them.

Also  alertImage is not being used.
Line 64:         // Generate the HTML for the image:
Line 65:         SafeHtml statusImageHtml =
Line 66:                 
SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(statusImage).getHTML());
Line 67:         sb.append(applicationTemplates.statusTemplate(statusImageHtml, 
tooltip));


-- 
To view, visit http://gerrit.ovirt.org/19611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to