anmolbabu has posted comments on this change. Change subject: webadmin : Change volume status to yellow when bricks down ......................................................................
Patch Set 6: (1 comment) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java Line 68: sb.append(alertImageHtml); Line 69: } Line 70: } Line 71: Line 72: public brickStatus isBrickDown(GlusterVolumeEntity volume) { the whole comparison and calculation is within this function.So,I am returning an enum to differentiate between the possible 3 cases. 1. No bricks down. 2. All bricks down. 3. One or more(but not all) bricks down Line 73: int count = 0; Line 74: for (GlusterBrickEntity brick : volume.getBricks()) { Line 75: if (brick.getStatus() == GlusterStatus.DOWN) { Line 76: count++; -- To view, visit http://gerrit.ovirt.org/19611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches