Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 11: > Again... it is not just this plugin it is the approach. If you do not work > with clear cut between components, you have one, two, three, many items to > remember. Then you end up with inability to actually remove all leftovers. > > I assume it should take ~10 minutes to revert the changes into distro-rpm and > perform simple grep on versionlock in legacy. 1. I agree it's a bit ugly. 2. "A simple grep" is also ugly IMO - it's duplication. 3. I think we actually do have a clear cut - all the code dealing with the versionlock file is in the same file. 4. I think we should treat the legacy plugin as something which is here to stay - we'll need to support it for at least a year or so. 5. I am also not sure we won't find a better solution to the versionlock ugliness and manage to get rid of it too some time soon - and if we do, this env item will be removed anyway, even if we forget to remove it when removing legacy... 6. As I already said and commented in the code, I am not at all certain we won't use this env item in other places. -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
