Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: weird message on cleanup if no db ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-common/db/connection.py Line 120: self.environment[otopicons.CoreEnv.LOG_FILTER].append( Line 121: dbenv[osetupcons.DBEnv.PASSWORD] Line 122: ) Line 123: Line 124: self.environment.update(dbenv) I understand that this was the intention of the original code, but can you show a real problem that this change can introduce? Do you prefer this [1] implementation? [1] http://gerrit.ovirt.org/19886 Line 125: dbovirtutils = database.OvirtUtils(plugin=self) Line 126: dbovirtutils.tryDatabaseConnect(dbenv) Line 127: self.environment[ Line 128: osetupcons.DBEnv.NEW_DATABASE -- To view, visit http://gerrit.ovirt.org/19840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I440e66c9f99377c8dda02681f5e0761c31fdc839 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
