Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: weird message on cleanup if no db ......................................................................
Patch Set 1: Note that this change changes the behavior quite significantly: Before it, the environment was updated with creds only if we managed to connect to the database, and with it, it's always updated. I did some tests, read all (?) relevant code, and see no problem with it. I did not test every possible flow. Notably, I did not test a remote/manual database. -- To view, visit http://gerrit.ovirt.org/19840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I440e66c9f99377c8dda02681f5e0761c31fdc839 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
