Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: weird message on cleanup if no db ......................................................................
Patch Set 1: > If it's only for having better cleanup handling you can preserve the previous > behavior if action is not a cleanup. Indeed, but: 1. I do not see a problem with updating the env, both from reading the relevant code and from testing. 2. With http://gerrit.ovirt.org/19839, if it's not a cleanup, and we fail connecting to the db, we exit anyway. -- To view, visit http://gerrit.ovirt.org/19840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I440e66c9f99377c8dda02681f5e0761c31fdc839 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
