Eli Mesika has posted comments on this change.

Change subject: [wip] core: Remove Windows ProductKey* from db
......................................................................


Patch Set 2:

(1 comment)

....................................................
File packaging/dbscripts/upgrade/03_03_0920_extract_product_keys.sh
Line 42:     tail -n+2 | \
Line 43:     sed -e 's/^ *//' -e 's/ *$//' -e 's/ *| */|/g' | \
Line 44:     grep -v '|$' | \
Line 45:     sed -e $SED_RULES > $CONF_FILE
Line 46: exit 0;
Yes, this is wrong 

Should be included in this shell script after values are exported successfully


-- 
To view, visit http://gerrit.ovirt.org/19743
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to