Eli Mesika has posted comments on this change. Change subject: core: Remove Windows ProductKey* from db ......................................................................
Patch Set 4: (2 comments) .................................................... File .gitignore Line 57: packaging/services/*/*.conf Line 58: packaging/setup/bin/ovirt-engine-setup.env Line 59: packaging/setup/ovirt_engine_setup/config.py Line 60: packaging/bin/ovirt-engine-log-setup-event.sh Line 61: packaging/dbscripts/upgrade/03_03_0950_extract_product_keys.sh This should not be here ! , plesae remove this line Line 62: ovirt-engine.spec Line 63: Line 64: # dbscripts Line 65: ########################### .................................................... File Makefile Line 174: packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv \ Line 175: packaging/setup/bin/ovirt-engine-setup.env \ Line 176: packaging/setup/ovirt_engine_setup/config.py \ Line 177: packaging/bin/ovirt-engine-log-setup-event.sh \ Line 178: packaging/dbscripts/upgrade/03_03_0950_extract_product_keys.sh \ again , no need for that , please remove this line Line 179: ovirt-engine.spec \ Line 180: $(NULL) Line 181: Line 182: all: \ -- To view, visit http://gerrit.ovirt.org/19743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
