Eli Mesika has posted comments on this change.
Change subject: [wip] core: Remove Windows ProductKey* from db
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
....................................................
File packaging/dbscripts/upgrade/03_03_0920_drop_product_key.sql
Line 1: -- Drops columns with Windows product keys as they are in osinfo.
vdc_options does not have these as columns, all are values in the option_name
column .
Please remove this script and apply my comment in the 0000_config.sql file
Line 2: SELECT fn_db_drop_column ('vdc_options', 'ProductKey2003');
Line 3: SELECT fn_db_drop_column ('vdc_options', 'ProductKey2003x64');
Line 4: SELECT fn_db_drop_column ('vdc_options', 'ProductKey2008');
Line 5: SELECT fn_db_drop_column ('vdc_options', 'ProductKey2008R2');
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 399: select fn_db_add_config_value('PostgresSearchTemplate',E'SELECT *
FROM (%2$s) %1$s) as T1 %3$s','general');
Line 400: select
fn_db_add_config_value('PredefinedVMProperties','sap_agent=^(true|false)$;sndbuf=^[0-9]+$;vhost=^(([a-zA-Z0-9_]*):(true|false))(,(([a-zA-Z0-9_]*):(true|false)))*$;viodiskcache=^(none|writeback|writethrough)$','3.0');
Line 401: select
fn_db_add_config_value('PredefinedVMProperties','sap_agent=^(true|false)$;sndbuf=^[0-9]+$;vhost=^(([a-zA-Z0-9_]*):(true|false))(,(([a-zA-Z0-9_]*):(true|false)))*$;viodiskcache=^(none|writeback|writethrough)$','3.1');
Line 402: select
fn_db_add_config_value('PredefinedVMProperties','sap_agent=^(true|false)$;sndbuf=^[0-9]+$;vhost=^(([a-zA-Z0-9_]*):(true|false))(,(([a-zA-Z0-9_]*):(true|false)))*$;viodiskcache=^(none|writeback|writethrough)$','3.2');
Line 403: select
fn_db_add_config_value('PredefinedVMProperties','sap_agent=^(true|false)$;sndbuf=^[0-9]+$;vhost=^(([a-zA-Z0-9_]*):(true|false))(,(([a-zA-Z0-9_]*):(true|false)))*$;viodiskcache=^(none|writeback|writethrough)$','3.3');
You should add in the delete section calls to fn_db_delete_config_value in
order to cleanup existing installations.
You can remove all versions of a key with one call , see examples in the file
(in the delete section)
Line 404: select
fn_db_add_config_value('ProductRPMVersion','3.0.0.0','general');
Line 405: select fn_db_add_config_value('QuotaGraceStorage','20','general');
Line 406: select fn_db_add_config_value('QuotaGraceVdsGroup','20','general');
Line 407: select fn_db_add_config_value('QuotaThresholdStorage','80','general');
--
To view, visit http://gerrit.ovirt.org/19743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
