Eli Mesika has posted comments on this change. Change subject: core: Adds entity DwhHistoryTimekeeping and variable heartBeat ......................................................................
Patch Set 3: (2 comments) .................................................... File packaging/dbscripts/dwh_history_timekeeping_sp.sql Line 1: ---------------------------------------------------------------- Line 2: -- [dwh_history_timekeeping] Table Line 3: ---------------------------------------------------------------- Line 4: Create or replace FUNCTION Updatedwh_history_timekeeping(v_var_name VARCHAR(50), please rename to: update_dwh_history_timekeeping or UpdateDwhHistoryTimekeeping Line 5: v_var_value VARCHAR(255), Line 6: v_var_datetime TIMESTAMP WITH TIME ZONE) Line 7: RETURNS VOID Line 8: AS $procedure$ Line 13: WHERE var_name = v_var_name; Line 14: END; $procedure$ Line 15: LANGUAGE plpgsql; Line 16: Line 17: Create or replace FUNCTION Getdwh_history_timekeepingByvar_name(v_var_name VARCHAR(50)) Please rename to: get_dwh_history_timekeeping_by_var_name or GetDwhHistoryTimekeepingByVarName Line 18: RETURNS SETOF dwh_history_timekeeping STABLE Line 19: AS $procedure$ Line 20: BEGIN Line 21: RETURN QUERY SELECT * -- To view, visit http://gerrit.ovirt.org/19366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34301ea921b2fda9fb0e09927b0417c0c096aca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
