Nir Soffer has posted comments on this change.
Change subject: webadmin: Display more accurate size of ISO files
......................................................................
Patch Set 3:
(2 comments)
Discuss what is human readable file size format.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
Line 13: }
Line 14:
Line 15: public enum Format {
Line 16: DEFAULT,
Line 17: FORMATTED
Both format are short and display the same information, so this does not apply
here.
Line 18: }
Line 19:
Line 20: private final DiskSizeUnit unit;
Line 21: private final Format format;
Line 13: }
Line 14:
Line 15: public enum Format {
Line 16: DEFAULT,
Line 17: FORMATTED
Human readable file size means showing the size in different units based on
size range. This concept is well known in various Unix tools such as ls, du,
df, in file managers, browsers etc.
Some applications such as ovirt-engine, or Firefox file:/// view, use simpler
format, where all files are displayed in the same unit (GB for ovirt-engine, KB
for Firefox). This format can be read by a human, but is not what people call
"human readable file size".
Using different units base on file size is *not* more precise then using single
unit. The most precise method is showing the file size in bytes, but it is
impossible to use when size become large. Using different units is less
precise, but more convenient.
For reference, try to search for "how to convert size to human readable format".
Line 18: }
Line 19:
Line 20: private final DiskSizeUnit unit;
Line 21: private final Format format;
--
To view, visit http://gerrit.ovirt.org/19550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
