Sergey Gotliv has posted comments on this change. Change subject: webadmin: Display more accurate size of ISO files ......................................................................
Patch Set 3: (4 comments) .................................................... Commit Message Line 9: Up until now DiskSizeRenderer which is used to render all image/disk/file Line 10: sizes had 3 limitations: Line 11: 1. Size appeared only in GB. Line 12: 2. All numbers were integers. Line 13: 3. Size smaller than 1GB appeared as '<1GB' Nothing wrong, actually some tabs continue with that behavior even after that patch. It had "3 limitations", I described those limitations and described additional behavior from now on. The world is not perfect but patches sometimes provide new functionality and not trying to fix something wrong. Line 14: Line 15: From now on, it supports MB, KB, and numbers with floating point. Line 16: Line 17: This patch uses new capability when displaing sizes of ISO files and floppies Line 11: 1. Size appeared only in GB. Line 12: 2. All numbers were integers. Line 13: 3. Size smaller than 1GB appeared as '<1GB' Line 14: Line 15: From now on, it supports MB, KB, and numbers with floating point. My goal was to create alternative to the current disk size format. It has nothing to do with "human readable" or "expected by users". Its more like "more accurate or precise", but this is arguable either. I prefer to leave it that way. Line 16: Line 17: This patch uses new capability when displaing sizes of ISO files and floppies Line 18: under Storage -> Images. Line 19: Line 14: Line 15: From now on, it supports MB, KB, and numbers with floating point. Line 16: Line 17: This patch uses new capability when displaing sizes of ISO files and floppies Line 18: under Storage -> Images. Nir, please, check Engine code to understand where else DiskSizeRenderer is used before reviewing this patch. DiskSizeRenderer is used in dozen places for example, the column which represents image sizes under VM -> Disks is rendered by this renderer, however the user experience there is the same as it was before. Maybe in the future I or you or someone else will change it, but this specific patch introduces new rendering format in one place only. Line 19: Line 20: Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a Line 21: Bug-Url: https://bugzilla.redhat.com/1005889 Line 15: From now on, it supports MB, KB, and numbers with floating point. Line 16: Line 17: This patch uses new capability when displaing sizes of ISO files and floppies Line 18: under Storage -> Images. Line 19: Yes, code should be called in order to work! I said exactly where this new behavior is introduced "This patch uses new capability when displaing sizes of ISO files and floppies under Storage -> Images", but you can't configure it!!! You can call appropriate constructor - but it understandable from code. Line 20: Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a Line 21: Bug-Url: https://bugzilla.redhat.com/1005889 -- To view, visit http://gerrit.ovirt.org/19550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
