Kanagaraj M has posted comments on this change.

Change subject: webadmin: gluster volume rebalance status popup
......................................................................


Patch Set 35:

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 138:                     return 
messages.rebalanceMovedFileSize(SizeConverter.SizeUnit.GB,SizeConverter.convert(size,
 SizeConverter.SizeUnit.BYTES, SizeConverter.SizeUnit.GB));
Line 139:                 } else if (size >  SizeConverter.BYTES_IN_MB) {
Line 140:                     return 
messages.rebalanceMovedFileSize(SizeConverter.SizeUnit.MB,SizeConverter.convert(size,
 SizeConverter.SizeUnit.BYTES, SizeConverter.SizeUnit.MB));
Line 141:                 } else if (size >  SizeConverter.BYTES_IN_KB) {
Line 142:                     return 
messages.rebalanceMovedFileSize(SizeConverter.SizeUnit.KB,SizeConverter.convert(size,
 SizeConverter.SizeUnit.BYTES, SizeConverter.SizeUnit.KB));
A new type of column can be introduced with a custom renderer
Line 143:                 }else {
Line 144:                     return 
messages.rebalanceMovedFileSize(SizeConverter.SizeUnit.BYTES, 
entity.getTotalSizeMoved());
Line 145:                 }
Line 146:             }


-- 
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Gerrit-PatchSet: 35
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to