anmolbabu has posted comments on this change.

Change subject: webadmin: gluster volume rebalance status popup
......................................................................


Patch Set 35:

(6 comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 562:                     
rebalanceStatusOk.setTitle(ConstantsManager.getInstance().getConstants().ok());
Line 563:                     rebalanceStatusOk.setIsCancel(true);
Line 564:                     cModel.getCommands().add(rebalanceStatusOk);
Line 565:                 } else {
Line 566:                     cModel.stopProgress();
Done
Line 567:                     setConfirmWindow(null);
Line 568:                     VolumeRebalanceStatusModel rebalanceStatusModel =
Line 569:                             new 
VolumeRebalanceStatusModel(volumeEntity);
Line 570:                     
rebalanceStatusModel.setTitle(ConstantsManager.getInstance()


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 2093: 
Line 2094:     @DefaultStringValue("Rebalance Status")
Line 2095:     String rebalanceStatusTitle();
Line 2096: 
Line 2097:     @DefaultStringValue("Fetching Data")
Done
Line 2098:     String rebalanceStatusFetchMessage();
Line 2099: }


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3239: 
Line 3240:     @DefaultStringValue("Rebalance completed")
Line 3241:     String rebalanceCompleted();
Line 3242: 
Line 3243:     @DefaultStringValue("Started At : ")
Done
Line 3244:     String rebalanceStartTime();
Line 3245: 
Line 3246:     @DefaultStringValue("Status At : ")
Line 3247:     String rebalanceStatusTime();


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
Line 92:             "BYTES", "{1} Bytes",
Line 93:             "KB", "{1} KB",
Line 94:             "MB", "{1} MB",
Line 95:             "GB", "{1} GB"
Line 96:     })
Done
Line 97:     String rebalanceMovedFileSize(@Select SizeConverter.SizeUnit 
sizeUnit, long size);
Line 98: 
Line 99:     @DefaultMessage("Rebalance {0}")
Line 100:     String rebalanceStatusMessage(JobExecutionStatus jobStatus);


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 109:         volumeEditor.setLabel(constants.rebalanceVolumeName());
Line 110:         clusterEditor.setLabel(constants.rebalanceClusterVolume());
Line 111:         statusTimeEditor.setLabel(constants.rebalanceStatusTime());
Line 112:         statusLabel.setText(constants.rebalanceComplete());
Line 113:         statusLabel.setVisible(false);
Done
Line 114:     }
Line 115: 
Line 116:     void initEditors(ApplicationConstants constants) {
Line 117:         rebalanceHostsTable = new 
EntityModelCellTable<ListModel>(false, true);


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.ui.xml
Line 31:                                    </g:VerticalPanel>
Line 32:                                    <g:VerticalPanel>
Line 33:                                        <e:EntityModelLabelEditor 
ui:field="clusterEditor" />
Line 34:                                        <g:HorizontalPanel>
Line 35:                                               
<e:EntityModelLabelEditor ui:field="statusTimeEditor" />
Done
Line 36:                                               <g:Label 
ui:field="statusLabel" />
Line 37:                                         </g:HorizontalPanel>
Line 38:                                    </g:VerticalPanel>
Line 39:                                </g:HorizontalPanel>


-- 
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Gerrit-PatchSet: 35
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to