Kanagaraj M has posted comments on this change.
Change subject: webadmin: gluster volume rebalance status popup
......................................................................
Patch Set 33:
(4 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 559:
cModel.setMessage(ConstantsManager.getInstance().getMessages().rebalanceStatusConfirmationMessage(((GlusterVolumeEntity)
getSelectedItem()).getName()));
Line 560: UICommand rebalanceStatusOk = new
UICommand("rebalanceNotStarted", VolumeListModel.this);//$NON-NLS-1$
Line 561:
rebalanceStatusOk.setTitle(ConstantsManager.getInstance().getConstants().ok());
Line 562: rebalanceStatusOk.setIsDefault(true);
Line 563: rebalanceStatusOk.setIsCancel(false);
setIsDefault should not set here, and setIsCancel should be true
Line 564: cModel.getCommands().add(rebalanceStatusOk);
Line 565: } else {
Line 566: cModel.stopProgress();
Line 567: setConfirmWindow(null);
Line 584: }
Line 585: }
Line 586: }),
Line 587: ((GlusterVolumeEntity)
getSelectedItem()).getClusterId(),
Line 588: ((GlusterVolumeEntity) getSelectedItem()).getId());
Instead of type casting multiple times, you could introduce a local variable to
hold the selected volume
Line 589: }
Line 590:
Line 591: private void cancelRebalanceStatus() {
Line 592: if (getWindow() == null)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 190:
Line 191: object.getPropertyChangedEvent().addListener(new
IEventListener() {
Line 192: @Override
Line 193: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 194: // TODO Auto-generated method stub
Remove this
Line 195: PropertyChangedEventArgs e =
(PropertyChangedEventArgs) args;
Line 196: if(e.PropertyName.equals("IS_STATUS_APPLICABLE"))
{//$NON-NLS-1$
Line 197:
statusLabel.setVisible(object.isStatusAvailable());
Line 198: }else {
Line 196: if(e.PropertyName.equals("IS_STATUS_APPLICABLE"))
{//$NON-NLS-1$
Line 197:
statusLabel.setVisible(object.isStatusAvailable());
Line 198: }else {
Line 199: statusLabel.setVisible(false);
Line 200: }
no need for the else block
Line 201: }
Line 202: });
Line 203: }
Line 204:
--
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Gerrit-PatchSet: 33
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
