Roy Golan has posted comments on this change. Change subject: engine: nullify EmulatedMachine field only on cluster level change ......................................................................
Patch Set 2: -Code-Review good catch by Omer - if hosts are up during the upgrade then the refreshCapabilities won't run and the cluster emulated machine value will be null. to overcome this we rely on the fact that the canDo of UpdateVdsGroup is checking that all hosts support the new compat version. if all hosts support the new version than we can pick a random UP host and run the auto-detection code for emulated machine against it I will add my code to this patch -- To view, visit http://gerrit.ovirt.org/18898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ffb180cfcd56c50b9bc228c0043e6fd5fee1c58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
