Tomas Jelinek has posted comments on this change.
Change subject: engine: nullify EmulatedMachine field only on cluster level
change
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
Line 61: for (VDS vds : allForVdsGroup) {
Line 62: if (getVds().getStatus() == VDSStatus.Up) {
Line 63: emulatedMachine = ListUtils.firstMatch(
Line 64:
Config.<List<String>>GetValue(ConfigValues.ClusterEmulatedMachines,
Line 65:
vds.getVdsGroupCompatibilityVersion().getValue()),
vds.getSupportedEmulatedMachines().split(","));
are you sure that this vds.getVdsGroupCompatibilityVersion().getValue()? Not
the new one? Like:
...
emulatedMachine = ListUtils.firstMatch(
Config.<List<String>>GetValue(ConfigValues.ClusterEmulatedMachines,
getParameters().getVdsGroup().getcompatibility_version()),
vds.getSupportedEmulatedMachines().split(","));
...
Line 66: break;
Line 67: }
Line 68: }
Line 69: if (emulatedMachine != null) {
--
To view, visit http://gerrit.ovirt.org/18898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ffb180cfcd56c50b9bc228c0043e6fd5fee1c58
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
