Yair Zaslavsky has posted comments on this change. Change subject: core: Refactor images adding flows ......................................................................
Patch Set 1: Answers to comments - a. I think the try/catch does not contribute anything meaningful besides some logging (talking about BaseImagesCommand.AddDiskImageToDb) b. A dynamic entry should be added, look at the original code - copy paste there of Image Dynamic addition. I think this copy paste code should be centerlized in one place. c. My plan for mocking was by introducing getImagesHandler() at BaseImagesCommand. -- To view, visit http://gerrit.ovirt.org/3196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8247f676354ec8ffa02e26daf430297a8859c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
