Yair Zaslavsky has submitted this change and it was merged. Change subject: DO NOT SUBMIT core: Fix admin login (#803380) ......................................................................
DO NOT SUBMIT core: Fix admin login (#803380) https://bugzilla.redhat.com/803380 This patch fixes a scenario in which a group was granted super user role on system, but one of its users was not added to the system. The user will fail to login, as it does not exist in DB and its Id cannot be used for MLA information extracting from DB. The solutuion shifts the DB addition after the authentication part, as was prior to the fix of https://bugzilla.redhat.com/784014 ("user already logged in" error when trying to log in) But still maintains seperation from setting the user on the session (So in LoginAdminUserCommand it will be possible to set this after the call to MLA). Change-Id: I133b9cb148dfad2fa678864046a5ee34c37f3895 Acked-By: --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginAdminUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 2 files changed, 6 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133b9cb148dfad2fa678864046a5ee34c37f3895 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
