Itamar Heim has posted comments on this change. Change subject: core: Fix admin login (#803380) ......................................................................
Patch Set 2: aren't the semantics each user that succeeds to login is added to the users table, regardless of permissions today? what happens if engine crashed between adding to table and removal? in general, adding a user to a table to remove it later sounds suspicious? -- To view, visit http://gerrit.ovirt.org/3114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I133b9cb148dfad2fa678864046a5ee34c37f3895 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
