Yair Zaslavsky has posted comments on this change. Change subject: core: Fix admin login (#803380) ......................................................................
Patch Set 2: Regarding adding to db - not current in current code (maybe we had that in the past) - currently user is added only after auhorized by MLA. Regarding server crashing between adding to table and removal - this is why I used transaction to wrap this code. The user will be removed only upon failure. This is required as we rely on DB for the calculation (I admit I would have preferred not to do this if possible). -- To view, visit http://gerrit.ovirt.org/3114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I133b9cb148dfad2fa678864046a5ee34c37f3895 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
