Maor Lipchuk has posted comments on this change.
Change subject: engine: Adding tests for VdcQueryType
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
Line 61:
Since it's only a getter method, there is no risk for it to be set, the member
it self is still private.
I looked at the TestHelperQueriesCommandType, and actually it could be much
helpful for our other tests, I think I will use it in here, instead changing
the access level of the method.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java
Line 83: public void testQueryType() {
IMO It's the same, will change as you suggested..
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractUserQueryTest.java
Line 63:
No, here I also check the it is a *user* auth type, in the other test I check
only the query name.
BTW those are two separated tests.
--
To view, visit http://gerrit.ovirt.org/2438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6591190bc5f4a7d9445eea1ecd34da0c79564e25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
