Moti Asayag has posted comments on this change.
Change subject: core : Refactoring of disks related commands
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 141:
This could be pulled to VmCommand since is constantly repeated in most of Vm
commands.
Line 156: String[] oses = Config.<String>
GetValue(ConfigValues.HotPlugSupportedOsList).split(",");
why not to have it static ? the list is not expected to change during run, so
no need to parse it for each command.
--
To view, visit http://gerrit.ovirt.org/2731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I460986b12f96f0fe3511e28265bd8d71d678f223
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
