Michael Kublin has posted comments on this change. Change subject: core : Refactoring of disks related commands ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java Line 45: Backend.getInstance().getResourceManager().RunVdsCommand( Done Line 47: getVm().getId(), diskImage, vmDevice)); no, at case of failure an exception will be thrown .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmDiskParameters.java Line 8: private Guid privateImageId = Guid.Empty; Done -- To view, visit http://gerrit.ovirt.org/2731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460986b12f96f0fe3511e28265bd8d71d678f223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
