Omer Frenkel has posted comments on this change. Change subject: core : Refactoring of disks related commands ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java Line 47: getVm().getId(), diskImage, vmDevice)); i think you should check the result of the hot plug operation and use it to decide if to update and setSucceeded .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmDiskParameters.java Line 8: private Guid privateImageId = Guid.Empty; maybe just call it imageId? -- To view, visit http://gerrit.ovirt.org/2731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460986b12f96f0fe3511e28265bd8d71d678f223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
