Moti Asayag has posted comments on this change.

Change subject: Introduce virt_service and gluster_service at cluster level
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File 
backend/manager/dbscripts/upgrade/03_01_0560_add_service_columns_to_vds_groups.sql
Line 1: --Add virt_service and gluster_service fields into vds_group
the sequence number 0560 is already taken. please verify uniqueness before 
submitting the patch.

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 119:     @XmlElement(name = "VirtService")
Please remove the @XmlElement annotations as not in use nomore.

Line 123:     @XmlElement(name = "GlusterService")
same

--
To view, visit http://gerrit.ovirt.org/2506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75e63378c68458ec4230c3cb904e0ed2ac28a483
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to