Itamar Heim has posted comments on this change. Change subject: Introduce virt_service and gluster_service at cluster level ......................................................................
Patch Set 1: > We've already identified that going forward we will want to > support other service types as well, esp. once we get rid > of the pool and are able to manage host groups per VM. > Adding a column to the db per service hardly seems scalable > (changing db scheme for every service we add?) I think it > would be better to add a mapping table (cluster / service). we know we want more service oriented approach. we still don't know how exactly. this is actually why the patch uses a boolean flag on cluster entity, to allow much more time to model how the service approach would look like rather than try something when much longer discussions on how services would look like is needed. so boolean flags were used since they will not cause a potentially harder to upgrade from services implementation, and should be very easy to upgrade from cluster entities with boolean flags this patch has to a service level approach, when one is modeled and implemented. -- To view, visit http://gerrit.ovirt.org/2506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75e63378c68458ec4230c3cb904e0ed2ac28a483 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
