Eli Mesika has posted comments on this change.
Change subject: core: Refactoring the CreateVDSCommand
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
Line 106: mCreateInfo.add(VdsProperties.kvmEnable,
mVm.getkvm_enable().toString()
Sorry, do not understand , which device order am I changing here ?
Line 176: drive.put("index",
String.valueOf(ideIndexSlots[ideCount]));
Since IdeIndexSlots array is set to {0,1,3} , this can not happen ....
Line 186: // ISCI not supported
on phase II
Line 240: if (!StringHelper.isNullOrEmpty(macs.toString().trim())) {
Why, the only place when we use the Index is when we are defining the disks,
how do you see that this affects device ordering ???
--
To view, visit http://gerrit.ovirt.org/1151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a0d4a4dfc868775a7e31c6bc6c7f3eae2ab2ee3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
