Yair Zaslavsky has posted comments on this change. Change subject: core: Refactoring the CreateVDSCommand ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java Line 304: Matcher regexMatcher = regexPattern.matcher(soundDeviceTypeConfig); Eli, Since you uploaded a new version of the patch, I would like to say that I agree with you that holding the compiled patterns per OS may be handled in a separate patch in this patchset. -- To view, visit http://gerrit.ovirt.org/1151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a0d4a4dfc868775a7e31c6bc6c7f3eae2ab2ee3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
