Doron Fediuck has posted comments on this change.
Change subject: core: Refactoring the CreateVDSCommand
......................................................................
Patch Set 2: (6 inline comments)
Eli,
missed these remarks from set #2...
Can you take a look?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
Line 56
AFAIR, method name should begin with a non-capital letter.
Why did you change it?
Line 106: mCreateInfo.add(VdsProperties.kvmEnable,
mVm.getkvm_enable().toString()
Isn't this changing the device order?
Line 176: drive.put("index",
String.valueOf(ideIndexSlots[ideCount]));
Since ideIndexSlots is limited to max of 4, please try to catch
index out of bounds here.
Line 186: // ISCI not supported
Please output to debug.
Line 240: if (!StringHelper.isNullOrEmpty(macs.toString().trim())) {
Previously, this part was after display network.
This seems to change the device ordering!!!
Line 294: final String DEFAULT_TYPE = "default";
The regex stuff looks very ugly...
Can we move to a more sane enum?
--
To view, visit http://gerrit.ovirt.org/1151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a0d4a4dfc868775a7e31c6bc6c7f3eae2ab2ee3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
