On Tue, 2003-11-04 at 13:19, Jon Smirl wrote: > --- Eric Anholt <[EMAIL PROTECTED]> wrote: > > On Tue, 2003-11-04 at 12:25, Otto Solares wrote: > > > On Mon, Nov 03, 2003 at 09:09:58PM -0800, Jon Smirl wrote: > > > > I currently have this info tacked onto the end of the statistics IOCTL > > (in > > > > order to conserve IOCTL numbers) but there should be a better way to do > > it. > > > > > > while you are on it, can you check why DRM_IOCTL_SET_UNIQUE ioctl does need > > root > > > privileges, it is more useful if access permissions could be managed via > > the > > > filesystem (eg. /dev/dri/cardX). > > > > You shouldn't use SET_UNIQUE any more. Do SET_VERSION to 1.1 and then > > get the unique (the busid). > > This doesn't need root priv, right?
Well, it doesn't need root privs, but I don't see where you're going really with trying to set up the DRM without root privs. Who does the addbufs and mapping? > Also, I wrote code to add get FB/MMIO size/length via the GetValue IOCTL for > Radeon. Should I stick with a card specific IOCTL for this or do we want a > general one? It's only the radeon DSO that needs this info. > > GetValue also returns the IRQ # for radeon, not sure what the othe cards do. > GetIRQByBusID can probably easily be eliminated too. > > I'm starting to think that it might be possible to eliminate all need for root > priv but it will take significantly more work. I was going to add exporting of FB/MMIO size/length as a separate but standard DRM ioctl. It's cleaner that way I think. I don't think we have any real limit on the number of ioctls, so let's not make it a device-specific thing if there isn't a need. DRM_IOCTL_IRQ_BUSID will be deprecated soon, at least lobotomized to only return the IRQ of the device the DRM is attached to. It'll actually be unnecessary when I make DRM(control) not care about the irq number that's passed in and only attach to the device's IRQ. -- Eric Anholt [EMAIL PROTECTED] http://people.freebsd.org/~anholt/ [EMAIL PROTECTED] ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
