I had some questions about patch 1, but patches 2 and 3 are: Reviewed-by: Iago Toral Quiroga <[email protected]>
El mié, 10-06-2026 a las 19:50 -0300, Maíra Canal escribió: > Being brief, this small series collects a correctness fix (#1) > reported by > Sashiko, a error-path fix (#2) reported by Sashiko, and a cleanup > (#3) > found while reading the code. > > The first patch is the only notable one: a v3d submission expands > into a > chain of jobs (e.g. BIN + RENDER + CACHE CLEAN), but the BO list was > only > ever attached to the last job. Since implicit synchronization is > added > per-job and gated on job->bo_count, every job before the last one > silently > skipped implicit dependencies. In practice the binning job could read > a > buffer object while another context was still writing it. It's fixed > by > looking up the BOs onto every job that references them. > > Best regards, > - Maíra > > --- > Maíra Canal (3): > drm/v3d: Associate BOs with every job that accesses them > drm/v3d: Reject invalid indirect BO handle in indirect CSD > setup > drm/v3d: Use write_to_buffer() helper in performance query copy > > drivers/gpu/drm/v3d/v3d_sched.c | 11 ++-------- > drivers/gpu/drm/v3d/v3d_submit.c | 43 ++++++++++++++++++++++-------- > ---------- > 2 files changed, 26 insertions(+), 28 deletions(-) > --- > base-commit: 2df5efb45425b48fbf5a3c1f36a686af26871009 > change-id: 20260609-v3d-cpu-job-fixes-fbe2051bee3a > >
