On 11/13/25 1:22 PM, Dmitry Baryshkov wrote: > On Thu, Nov 13, 2025 at 10:27:09AM +0100, Konrad Dybcio wrote: >> On 11/13/25 4:38 AM, Dmitry Baryshkov wrote: >>> On Thu, Nov 13, 2025 at 03:32:51AM +0530, Akhil P Oommen wrote: >>>> On 11/12/2025 3:52 PM, Konrad Dybcio wrote: >>>>> On 11/10/25 5:37 PM, Akhil P Oommen wrote: >>>>>> In A6x family (which is a pretty big one), there are separate >>>>>> adreno_func definitions for each sub-generations. To streamline the >>>>>> identification of the correct struct for a gpu, move it to the >>>>>> catalogue and move the gpu_init routine to struct adreno_gpu_funcs. >>>>>> >>>>>> Signed-off-by: Akhil P Oommen <[email protected]> >>>>>> --- >>>>> >>>>> [...] >>>>> >>>>> >>>>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>>>> b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>>>> index 44df6410bce1..9007a0e82a59 100644 >>>>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>>>> @@ -683,7 +683,7 @@ static const struct adreno_info a6xx_gpus[] = { >>>>> >>>>> Somewhere among this diff, a619_holi needs to have gmu_wrapper funcs >>>> >>>> Could you point me to the holi's devicetree? Currently I see only a610 >>>> (sm6115) and a702 (qcm2290) uses gmu_wrapper. >>> >>> I don't think upstream was ported to SM4350. SM6375 should need the same >>> hook, but I don't know why Konrad didn't enable GPU on that platform. >> >> I'll try to fire up -next and confirm it hasn't bitrotten. > > Maybe then a patch to enable it too?
I was hoping this would be implicitly obvious Konrad
